Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/3385_filter_account_popper_visibility #76

Merged
merged 8 commits into from
Oct 16, 2023

Conversation

shubhrathasetty
Copy link
Contributor

@plummip
Copy link
Contributor

plummip commented Oct 9, 2023

looks good! thank you.

Can we just implement a null check on the query selector when focussing the first input?
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining
moving the cursor to the end might also be a good idea so we are sure that we can start typing from the end.

    // Move the cursor to the end
    const length = fullNameEle.value.length;
    fullNameEle.setSelectionRange(length, length);

Copy link
Contributor

@tdegrunt tdegrunt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're losing functionality it seems?

this._tableWrpHeight ||= tableWrap?.style.minHeight
tableWrap.style.minHeight = `${popperHeight}px`
}
const firstInputEle = this.popperInstance.state.elements.popper.querySelector('form input:not([class=hidden])')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use full names for variables (firstInputElement).
Should we also look for selects/textarea?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approved the changes. we only now have a bug for the tables that are on the lower end of the page.. (e.g. last table on the sales order overview)
textarea indeed, i dont know if we use it to filter on anything though. we just put focus on it so we can start typing a query without having to actually move into the dropdown/textfield to start typing the query. it saves one click.

Do we use selects?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope selected value will be prepopulated in input area

@shubhrathasetty shubhrathasetty merged commit 75cd986 into develop Oct 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants