Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mob] Allow manual upload of videos when global video upload is disabled #1384

Merged
merged 2 commits into from
Apr 9, 2024
Merged

[mob] Allow manual upload of videos when global video upload is disabled #1384

merged 2 commits into from
Apr 9, 2024

Conversation

ua741
Copy link
Member

@ua741 ua741 commented Apr 9, 2024 •
edited
Loading

Description

See commit message.

PS: Did not write code to clean up the list as I don't expect the list to grow significantly.

Fix #1276

Tests

  • Disabled Global Video Upload

Before the change

  • Clicking on upload icon on video was not resulting in the upload of the underlying video.

After the change

  • Upload upload went through successfully

@ua741 ua741 enabled auto-merge April 9, 2024 04:06
@ua741 ua741 requested a review from ashilkn April 9, 2024 04:09
@ua741 ua741 merged commit 7c82b57 into main Apr 9, 2024
2 checks passed
@ua741 ua741 deleted the mob_upload branch April 9, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishnukvmd vishnukvmd vishnukvmd approved these changes

@ashilkn ashilkn Awaiting requested review from ashilkn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spinner Icon in loop when uploading video with backup videos disabled
2 participants
@ua741 @vishnukvmd