[mob][panorama] update panorama checking mechanism #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ua741
reviewed
Aug 2, 2024
mobile/lib/utils/panorama_util.dart
Outdated
| final result = await checkIfPanorama(file); | ||
|
|
||
| // Update the metadata if it is not updated | ||
| if (file.isPanorama() == null && file.canEditMetaInfo) { |
There was a problem hiding this comment.
file.canEditMetaInfo check can happen at the start of the method
mobile/lib/models/file/file.dart
Outdated
Comment on lines
184
to
192
| mediaUploadData.isPanorama = checkPanoramaFromEXIF(null, exifData); | ||
|
|
||
| try { | ||
| final xmpData = XMPExtractor() | ||
| .extract(mediaUploadData.sourceFile!.readAsBytesSync()); | ||
| mediaUploadData.isPanorama = checkPanoramaFromXMP(xmpData); | ||
| } catch (_) {} | ||
|
|
||
| mediaUploadData.isPanorama ??= false; |
There was a problem hiding this comment.
These check should only happen for Normal Images (not for Live photo and video).
Also, if exifSays it's panorama, no need to check for xmp?
There was a problem hiding this comment.
For the first part, it is under a if where it only runs for file type image, hence file type live photo and video are eliminated.
ua741
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Panorama was getting checked every time and was not getting cached. This PR creates mediaType to classify image whether it's panorama or not.