Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Optimize and improve icons #2843

Merged
merged 6 commits into from
Aug 25, 2024
Merged

Conversation

shmshd
Copy link
Contributor

@shmshd shmshd commented Aug 23, 2024

Overall custom_icons directory size improvement is from 1.3M -> 704K

Replaced image data icons:

  • 3commas
  • Addy_io
  • Bitskins
  • Bitvavo
  • Configcat
  • Controld
  • Kpn
  • Marketplacedottf
  • Odido
  • Peerberry
  • Porkbun
  • Skinport
  • Tweakers
  • Wise

Optimized icons:

  • Bitwarden
  • Bloom_host
  • Booking
  • Brave_creators
  • Cloudamqp
  • Cloudflare
  • Epic_games
  • Google
  • HuggingFace
  • Kraken
  • Mintos
  • Mistral
  • MyFritz
  • Notion
  • Nucommunity
  • Nvidia
  • Rockstar_games
  • Samsung
  • Sms_pool_net
  • Synology_dsm
  • Teleport
  • Twitch
  • Ubisoft
  • Uphold
  • Whmcs
  • Windscribe
  • Ynab

Improved icons:

  • LocalWP
  • Mercado_livre
  • Transip
  • Twingate
  • Ubuntu_one
  • Wyze
  • Yandex

Fixed icons:

  • Workos
  • Poloniex
  • Proxmox
  • Registro_br

@ua741 ua741 merged commit 09da5ca into ente-io:main Aug 25, 2024
1 check passed
@tanguylegazon
Copy link
Contributor

Hey there @shmshd! You've done a great job cleaning all this up!

I noticed your recent change to the Proxmox icon, and I think there might be a small issue. The original icon used mix-blend-mode:difference to adjust its visibility depending on whether light or dark mode was active, which helped with accessibility. With you commit, the icon is now black all the time, making it hard to see in dark mode.

Here is an example with the previous version:
Group 1

VS 0aaf5c6:
Group 2

@shmshd
Copy link
Contributor Author

shmshd commented Sep 2, 2024

@Eseltwift I missed mix-blend-mode. Could you check others as well as create a PR to fix these?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants