Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Add icon for GOV.UK #3132

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[Auth] Add icon for GOV.UK #3132

merged 2 commits into from
Sep 12, 2024

Conversation

bsian03
Copy link
Contributor

@bsian03 bsian03 commented Sep 4, 2024

Adds the icon for UK government online services (Government Gateway)

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024

CLA assistant check
All committers have signed the CLA.

@tanguylegazon
Copy link
Contributor

Hey, I think you should add a fill color for the mix-blend-mode mode to work properly.

You could do something like this:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 30">
<g style="mix-blend-mode:difference">
- <path d="M22.6 ... 12.3-.8"/>
+ <path fill="white" d="M22.6 ... 12.3-.8"/>
</g>
</svg>

Without an actual background coded in (as it would be in a web browser, for example), the SVG will appear white on white, but in the app, it will display correctly.

@bsian03
Copy link
Contributor Author

bsian03 commented Sep 4, 2024

Thanks, must have missed it looking at the github svg as the example

@ua741 ua741 merged commit 4c7d3a3 into ente-io:main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants