Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Switch on default warning flag for CI test command #326

Merged
merged 1 commit into from
Oct 21, 2020
Merged

TST: Switch on default warning flag for CI test command #326

merged 1 commit into from
Oct 21, 2020

Conversation

aaronayres35
Copy link
Contributor

fixes #311

This PR makes the exact same fix that was done in enthought/traitsui#1059. It adds the adds the -W default flag.

rahulporuri
rahulporuri approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@rahulporuri rahulporuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kitchoi kitchoi merged commit d2aff55 into master Oct 21, 2020
@kitchoi kitchoi deleted the fix-311-default-warning-flag branch October 21, 2020 08:34
@aaronayres35 aaronayres35 mentioned this pull request Oct 28, 2020
Merged
@aaronayres35 aaronayres35 mentioned this pull request Dec 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahulporuri rahulporuri rahulporuri approved these changes

@kitchoi kitchoi Awaiting requested review from kitchoi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch on the default warning flag when running testsuite
3 participants
@aaronayres35 @rahulporuri @kitchoi