Fix an order-dependency bug in the test_subclasses_weakref regression test #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I don't have proof that this was the cause of #1282, and I haven't managed to reproduce locally. Nevertheless, it seems very likely that this was the issue, so assuming that the CI passes with this PR I'm content to close #1282 (and re-open if the error re-appears). See also: https://stackoverflow.com/questions/51233073/python-subclasses-order |
4 tasks
|
Thanks, @rahulporuri! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use assertCountEqual rather than assertEqual so as not to depend on order. Should fix #1282.