Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a DeprecationWarning for configure_traits() pickles #792

Merged
merged 2 commits into from
Jan 23, 2020

Conversation

jwiggins
Copy link
Member

Somewhat related to #787, we should deprecate the use of pickles for saving state between invocations of configure_traits.

@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@d470c89). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #792   +/-   ##
=========================================
  Coverage          ?   72.07%           
=========================================
  Files             ?       51           
  Lines             ?     6346           
  Branches          ?     1279           
=========================================
  Hits              ?     4574           
  Misses            ?     1377           
  Partials          ?      395
Impacted Files Coverage Δ
traits/has_traits.py 70.38% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d470c89...4936a23. Read the comment docs.

@mdickinson
Copy link
Member

Thanks. Do you have bandwidth to add a test for the deprecation? (Just an assertWarns should be enough.)

@jwiggins
Copy link
Member Author

Do you have bandwidth to add a test for the deprecation?

Possibly not today. How close is the next release?

@mdickinson
Copy link
Member

How close is the next release?

Not yet determined, but we may target the end of next week. Not today, anyway.

Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but needs a test.

@mdickinson
Copy link
Member

I added the appropriate self.assertWarns to existing tests.

@mdickinson mdickinson merged commit 5691120 into master Jan 23, 2020
@mdickinson mdickinson deleted the feature/deprecate-ui-pickles branch January 23, 2020 17:01
@jwiggins
Copy link
Member Author

Thanks for finishing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants