-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a DeprecationWarning for configure_traits() pickles #792
Conversation
Codecov Report
@@ Coverage Diff @@
## master #792 +/- ##
=========================================
Coverage ? 72.07%
=========================================
Files ? 51
Lines ? 6346
Branches ? 1279
=========================================
Hits ? 4574
Misses ? 1377
Partials ? 395
Continue to review full report at Codecov.
|
Thanks. Do you have bandwidth to add a test for the deprecation? (Just an |
Possibly not today. How close is the next release? |
Not yet determined, but we may target the end of next week. Not today, anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but needs a test.
I added the appropriate |
Thanks for finishing this! |
Somewhat related to #787, we should deprecate the use of pickles for saving state between invocations of
configure_traits
.