Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#132 add return type to constructor definition #133

Merged
merged 1 commit into from
May 22, 2018
Merged

#132 add return type to constructor definition #133

merged 1 commit into from
May 22, 2018

Conversation

alex-sherwin
Copy link
Contributor

The existing constructor type definition without a return type does not compile when tsconfig.json is setup with strict mode enabled

@coveralls
Copy link

coveralls commented May 22, 2018 •
edited

Coverage Status

Coverage remained the same at 98.551% when pulling 3bf732f on alex-sherwin:develop into bd69b7a on entrecode:develop.

@simon-scherzinger simon-scherzinger merged commit 120dd75 into entrecode:develop May 22, 2018
@simon-scherzinger
Copy link
Member

simon-scherzinger commented May 22, 2018 •
edited

Alright, looks good. 👍
released with 0.4.7, keep in mind that npm is having issues currently with new publishes. (see https://status.npmjs.org/incidents/3rjzvts6v98k)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alex-sherwin @coveralls @simon-scherzinger