Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add keys to gestures, so the sender (owner) can be identified #217

Merged
merged 1 commit into from
Apr 19, 2023
Merged

add keys to gestures, so the sender (owner) can be identified #217

merged 1 commit into from
Apr 19, 2023

Conversation

BentEngbers
Copy link
Contributor

@BentEngbers BentEngbers commented Apr 13, 2023 •
edited
Loading

This PR adds keys to all gestures, so the original graph can be identified.

@entronad
Copy link
Owner

entronad commented Apr 14, 2023 •
edited
Loading

#202

@entronad
Copy link
Owner

entronad commented Apr 14, 2023 •
edited
Loading

Good, but a small suggestion that this param of Gesture is better named chartKey, or it may seem unique for a Gesture not a Chart.

@entronad entronad merged commit 53563ad into entronad:main Apr 19, 2023
@entronad
Copy link
Owner

Updated in v2.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BentEngbers @entronad @LucaCras