Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix numeric angles need to be specified as RotationAngle objects too #91

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

vishal-ph
Copy link
Collaborator

@vishal-ph vishal-ph commented Sep 28, 2022

Description

  • Some fixed angles for the gates in GateMap decomposition are specified directly as numeric values. This breaks the code when these GateMap objects use any decomposition other than trivial. This can be quickly rectified by wrapping these numeric angles inside a RotationAngle object. This PR implements this fix

Checklist

  • I have performed a self-review of my code.
  • My changes generate no new warnings
  • I have added/updated tests to make sure bugfix/feature works.
  • New and existing unit tests pass locally with my changes.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #91 (235e72c) into dev (833e3ed) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##              dev      #91   +/-   ##
=======================================
  Coverage   89.48%   89.48%           
=======================================
  Files          63       63           
  Lines        8099     8099           
=======================================
  Hits         7247     7247           
  Misses        852      852           
Impacted Files Coverage Δ
openqaoa/qaoa_parameters/gatemap.py 88.02% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vishal-ph vishal-ph merged commit fcb4ba7 into dev Sep 28, 2022
@vishal-ph vishal-ph deleted the bugfix_rotation_angles branch September 28, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants