Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commandline support (issue #5) #6

Merged
merged 6 commits into from
Aug 31, 2019
Merged

Add commandline support (issue #5) #6

merged 6 commits into from
Aug 31, 2019

Conversation

skjolber
Copy link
Contributor

Download commandline executable and run a scan.

@skjolber skjolber force-pushed the commandLine branch 12 times, most recently from e4a140d to 337a666 Compare August 30, 2019 07:06
@skjolber
Copy link
Contributor Author

Kanskje litt uheldig at man alltid må være på siste versjon av dependency-check? Kan legge til valgfri parameter for å sette versjonen.

@skjolber skjolber force-pushed the commandLine branch 7 times, most recently from 353d37d to 77576e8 Compare August 30, 2019 08:27
Copy link
Contributor

@tommybo-entur tommybo-entur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added some thoughts for you to consider.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/@orb.yml Outdated Show resolved Hide resolved
src/@orb.yml Outdated Show resolved Hide resolved
src/@orb.yml Outdated Show resolved Hide resolved
src/@orb.yml Outdated
description: Location of latest Dependency-Check command-line tool version (i.e. 5.2.1)
type: string
default: "https://jeremylong.github.io/DependencyCheck/current.txt"
executable_url:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an alternative you could expect the executing image to contain dependenct_check.sh. Perhaps even have a separate command for installing owasp.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll save that for a later version + might be sensible to also look at customizing the command-line arguments also for maven and gradle builds.

@skjolber skjolber merged commit 007ba22 into master Aug 31, 2019
@skjolber skjolber deleted the commandLine branch August 31, 2019 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants