-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commandline support (issue #5) #6
Conversation
e4a140d
to
337a666
Compare
Kanskje litt uheldig at man alltid må være på siste versjon av dependency-check? Kan legge til valgfri parameter for å sette versjonen. |
353d37d
to
77576e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Added some thoughts for you to consider.
src/@orb.yml
Outdated
description: Location of latest Dependency-Check command-line tool version (i.e. 5.2.1) | ||
type: string | ||
default: "https://jeremylong.github.io/DependencyCheck/current.txt" | ||
executable_url: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an alternative you could expect the executing image to contain dependenct_check.sh. Perhaps even have a separate command for installing owasp.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll save that for a later version + might be sensible to also look at customizing the command-line arguments also for maven and gradle builds.
Download commandline executable and run a scan.