Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add support for Azure DevOps templates #548

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

TomerHeber
Copy link
Collaborator

Issue & Steps to Reproduce / Feature Request

closes #547

Solution

  1. Added the new field.
  2. Updated acceptance tests.

Note: integration test not added. I could add the integration test if there is an existing template in the test account.

Copy link

@ItamarMalka ItamarMalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomerHeber Can you change those azure_dev_ops into azure_devops?
as it fits our naming scheme better
Other then that the PR looks great 👍

integration test not added. I could add the integration test if there is an existing template in the test account

We are doing these atm it should be there in the next couple of days

@TomerHeber
Copy link
Collaborator Author

@TomerHeber Can you change those azure_dev_ops into azure_devops? as it fits our naming scheme better Other then that the PR looks great 👍

integration test not added. I could add the integration test if there is an existing template in the test account

We are doing these atm it should be there in the next couple of days

@ItamarMalka sure!
The confusion was because in the API it's called "azureDevOps" (and not "azureDevops").

@TomerHeber
Copy link
Collaborator Author

@ItamarMalka c8ce38b

Copy link

@ItamarMalka ItamarMalka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Dec 5, 2022
@TomerHeber TomerHeber merged commit a64d590 into main Dec 5, 2022
@TomerHeber TomerHeber deleted the feat-add-azure-devops-#547 branch December 5, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-client feature provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Azure DevOps templates
2 participants