Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: custom flow support #564

Merged
merged 5 commits into from
Jan 11, 2023
Merged

Feat: custom flow support #564

merged 5 commits into from
Jan 11, 2023

Conversation

TomerHeber
Copy link
Collaborator

Solution

Part of custom flow effort #550

  1. Added the custom flow resource.
  2. Added acceptance tests.
  3. Added integration tests.

@TomerHeber TomerHeber self-assigned this Jan 7, 2023
@TomerHeber
Copy link
Collaborator Author

For the next PR (once this is approved):

  1. Add the assignment resource.
  2. Add examples to the documentation.

yarivg
yarivg reviewed Jan 10, 2023
View reviewed changes
env0/resource_custom_flow.go
Required: true,
},
"path": {
Type: schema.TypeString,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should indicate in the path description that it should be the full path including .yaml/.yml

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yarivg - good point. I will fix.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added.

HeverFarber
HeverFarber approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@HeverFarber HeverFarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added ready to merge PR approved - can be merged once the PR owner is ready and removed pending final review labels Jan 11, 2023
@yaronya yaronya merged commit 681f1ce into main Jan 11, 2023
@yaronya yaronya deleted the feat-custom-flow-#550_2 branch January 11, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeverFarber HeverFarber HeverFarber approved these changes

@yaronya yaronya Awaiting requested review from yaronya

@yarivg yarivg Awaiting requested review from yarivg

Assignees

@TomerHeber TomerHeber

Labels
api-client feature integration-tests provider ready to merge PR approved - can be merged once the PR owner is ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TomerHeber @HeverFarber @yarivg @yaronya