Fail the build if a specified role is missing specs #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viraptor
approved these changes
Feb 20, 2019
lib/ami_spec/server_spec.rb
Outdated
| @@ -40,6 +47,7 @@ def run | |||
|
|
|||
| RSpec.configuration.fail_fast = true if @debug | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
ooops. I've spent too long in javascript land, where prettier cleans up my mess for me ;)
patrobinson
reviewed
Feb 20, 2019
lib/ami_spec/server_spec.rb
Outdated
| puts "skip the role '#{@role}', create the directory but leave it empty" | ||
| puts "(except for a .gitkeep file)." | ||
| return false | ||
| end |
There was a problem hiding this comment.
Should this be done during initialization? Doing it during a run will spin up other AMIs to test still, despite an imminent failure. Otherwise a verify method might be useful?
There was a problem hiding this comment.
Yeah, I've just moved that in the latest commit.
mipearson
force-pushed
the
mp-fail-missing-role
branch
from
6b3a883
to
7daf1ed
Compare
patrobinson
reviewed
Feb 20, 2019
| unless Dir.exist?("#{options[:specs]}/#{role}") | ||
| fail "Role directory #{options[:specs]}/#{role} does not exist. If you'd like to skip the role '#{role}', create the directory but leave it empty (except for a .gitignore file)." | ||
| end | ||
| end |
There was a problem hiding this comment.
This only tests if we are using the file. We should also test when options[:ami] and options[:role] are supplied
There was a problem hiding this comment.
Further up in the file options[:role] && options[:ami] are co-erced into options[:amis]
patrobinson
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure on implementation here - I feel like there should be a more rspeccy way of doing this, preferably with a nice red rspec failure.
Anyway, this not failing fast caused lots of confusion as our passing build was not actually running tests against some of the roles it had been told to.