Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Faraday dependency to version 1 #85

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Upgrade Faraday dependency to version 1 #85

merged 1 commit into from
Dec 28, 2020

Conversation

orien
Copy link
Member

@orien orien commented Dec 28, 2020

https://rubygems.org/gems/faraday

Faraday is used by the Octokit gem and directly by Unwrappr in one spot (which works fine on version 1).

unwrappr/lib/unwrappr/ruby_gems.rb

Line 13 in e1736ef

parse(Faraday.get(SERVER + format(GET_GEM, name, version)), name)

@orien orien requested a review from johnsyweb December 28, 2020 21:34
@orien orien merged commit 4996bd5 into main Dec 28, 2020
@orien orien deleted the orien/faraday-v1 branch December 28, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joesustaric joesustaric joesustaric approved these changes

@johnsyweb johnsyweb johnsyweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orien @johnsyweb @joesustaric