envoy: c911818721586 #2107
Merged
envoy: c911818721586 #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2022 11:58
Signed-off-by: Jose Nino <jnino@lyft.com>
Signed-off-by: Jose Nino <jnino@lyft.com>
jpsim
reviewed
Mar 17, 2022
| @@ -326,6 +326,7 @@ R"( | |||
| dns_cache_config: *dns_cache_config | |||
| transport_socket: *base_tls_socket | |||
| upstream_connection_options: &upstream_opts | |||
| set_local_interface_name_on_upstream_connections: true | |||
There was a problem hiding this comment.
How much of a perf impact does this have for EM use cases compared to turning it off? Would it be worth offering as a config option or turning off when log level is set to some values?
There was a problem hiding this comment.
#2111 good point. Alternatively there is further work in upstream envoy that can make this functionality more performant.
For this PR though I'm biased to leave it on by default as that has been the case for all experiments we've run in the last quarter.
There was a problem hiding this comment.
Sure, I'm ok with that too, but was curious if you had measured the impact on us.
jpsim
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes envoyproxy/envoy#19758 so we now need to set the config option.
Will wait until @snowp resolves the upstream break in #2105 to land this