Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identifying stable release for a minor version #11091

Closed
aminjam opened this issue May 6, 2020 · 5 comments · Fixed by #11405
Closed

Identifying stable release for a minor version #11091

aminjam opened this issue May 6, 2020 · 5 comments · Fixed by #11405
Assignees

Comments

@aminjam
Copy link

aminjam commented May 6, 2020

Summary

As downstream consumers of envoy binary, we would like to find a process to discover and bump the envoy binary when a new version of a given minor has been released.

Facts

I see that in #10800 the community has stopped publishing latest tag for envoy docker image and I found the following Stable release of Envoy doc that describes the release schedule for a given minor version.

Problem

While it's technically possible to consume/watch the latest github release for enovy, extract the version info, and docker pull the given tag, there are a few downsides to this approach:

  1. There is no guarantee that the docker image has been pushed to dockerhub when the release is made
  2. All downstream consumers have to re-invent the same process in order to get the latest patched version of an envoy binary

Questions

  1. Would it be possible to have the downstream users consume a 1.minor.x (e.g. 1.14.x) docker image tag in order to get the latest patched envoy binary for a given minor?
  2. Is there a better workflow for consuming the latest patched envoy binary other than the docker image? We currently use the following docker image: envoyproxy/envoy
@mattklein123
Copy link
Member

Yes this occurred to me also to have a per-stable-version "latest" tag that users can track if they wish. Marking help wanted for someone to look into script updates. cc @lizan

@aminjam
Copy link
Author

aminjam commented Jun 2, 2020

@mattklein123 @lizan Is there any updates on this issue or thoughts about the path forward? I'd be happy to close this issue for now if there is no workaround or plan in the foreseeable future.

@sunjayBhatia
Copy link
Member

I can work up a PR for this, feel free to assign it to me

@lizan
Copy link
Member

lizan commented Jun 2, 2020

@aminjam per-stable-version "latest" tag sounds good to me.

@mattklein123
Copy link
Member

Please don't close this. We should definitely do this but we need someone to work on it. @sunjayBhatia that would be awesome!

@lizan lizan removed the help wanted Needs help! label Jun 2, 2020
lizan pushed a commit that referenced this issue Jun 3, 2020
Enables users of tagged releases to stay on the latest release of a
major/minor combination

Resolves #11091

Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
auni53 pushed a commit to auni53/envoy that referenced this issue Jun 4, 2020
Enables users of tagged releases to stay on the latest release of a
major/minor combination

Resolves envoyproxy#11091

Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: Auni Ahsan <auni@google.com>
PiotrSikora pushed a commit to PiotrSikora/envoy that referenced this issue Jun 5, 2020
Enables users of tagged releases to stay on the latest release of a
major/minor combination

Resolves envoyproxy#11091

Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora pushed a commit to PiotrSikora/envoy that referenced this issue Jun 5, 2020
Enables users of tagged releases to stay on the latest release of a
major/minor combination

Resolves envoyproxy#11091

Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora pushed a commit to PiotrSikora/envoy that referenced this issue Jun 5, 2020
Enables users of tagged releases to stay on the latest release of a
major/minor combination

Resolves envoyproxy#11091

Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora added a commit that referenced this issue Jun 6, 2020
Enables users of tagged releases to stay on the latest release of a
major/minor combination

Resolves #11091

Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora added a commit that referenced this issue Jun 6, 2020
Enables users of tagged releases to stay on the latest release of a
major/minor combination

Resolves #11091

Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora added a commit that referenced this issue Jun 6, 2020
Enables users of tagged releases to stay on the latest release of a
major/minor combination

Resolves #11091

Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
yashwant121 pushed a commit to yashwant121/envoy that referenced this issue Jul 24, 2020
Enables users of tagged releases to stay on the latest release of a
major/minor combination

Resolves envoyproxy#11091

Signed-off-by: Sunjay Bhatia <sbhatia@pivotal.io>
Signed-off-by: yashwant121 <yadavyashwant36@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants