-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default configs in Docker images dont work very well out of the box #13497
Comments
also noticing that they are using v2 configs (related to #13529 (comment)) |
@mattklein123 there are kinda 2 questions/propositions here use envoyproxy.io as default/demo proxyproxying http://localhost to https://anything.else is always going to be imperfect, but proxying to the envoy website works better than proxying to google and is more "neutral" i think. make admin listen on
|
@lizan do you have any thoughts on above suggestions ? |
I think both of these changes are fine with me, as long as we very carefully document the security implications of the admin config in the example. IIRC the google proxy used to work, so it would be nice to understand why it no longer works, but I guess that is a separate issue. I think proxying to the website as a neutral location makes sense to me. |
almost certainly Content Security Policy |
here is the (wip) bit in the updated quick start instructions https://storage.googleapis.com/envoy-pr/13490/docs/start/quick-start.html#configuration-admin |
thinking about this further - this is how it is already documented. So the only change i think is to the config in the Docker image |
It does matter if you run with |
im sure the image is used in many different ways - but the default config - ie the one that proxies to google etc is less likely to be used in this way. currently we have the worst of all worlds. The Docker image config doesnt work, and the documentation encourages you to listen on |
the other option - which i think is not a bad idea - remove the config altogether (as getenvoy does i think) |
This updates the defaut container config to: - use the envoyproxy.io website as the default upstream proxy - listen for admin interface on 0.0.0.0 address Fixes #13497 Signed-off-by: Ryan Northey <ryan@synca.io>
This updates the defaut container config to: - use the envoyproxy.io website as the default upstream proxy - listen for admin interface on 0.0.0.0 address Fixes envoyproxy#13497 Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Craig Radcliffe <craig.radcliffe@broadcom.com>
description
The default Envoy docker image comes with an example configuration that:
127.0.0.1:9901
with an admin interfacehttp
0.0.0.0:10000
tohttps
www.google.comRunning this with
...and browsing to http://localhost:PORT neither works very well.
The admin doesnt work at all out-of-the-box because its listening to
127.0.0.1
The google proxy creates an overlay with a spinning wheel and borks (im guessing that playing with eg
/etc/resolv.conf
it might work differently)I would propose that we change and/or document the admin UI
For the proxy, how about we proxy to the www.envoyproxy.io website
refs
The text was updated successfully, but these errors were encountered: