Feature Request: Support adding/removing query params

[sethpollack]

In Nginx you can modify query params with something like set $args $args&api_key=foo;

We can do something similar with query_params_to_add and query_params_to_remove

[dalegaspi]

i just assumed this is supported out of the box. 😞

is there a plan to get this feature added?

edit: ok i was able to do this using a Lua filter and I suppose for now this will do.

http_filters:
  - name: envoy.filters.http.lua
    typed_config:
      '@type': type.googleapis.com/envoy.config.filter.http.lua.v2.Lua
      inline_code: |
        function envoy_on_request(request_handle)
          path = request_handle:headers():get(":path")
          request_handle:headers():replace(":path", (path .. "&my-param=yeet"))
        end
  - name: envoy.router

note that the above code is very fragile since it assumes it's a GET, and assumes there's existing params, et cetera, et cetera...

[siddharthkhonde]

hi. is this still open? I can take a look into this as a beginner.

[derekargueta]

@alyssawilk @mattklein123 started working on this issue implementing it within the router similar to request_headers_to_add/remove but had a thought - would it be better to implement this as an HTTP filter? This thought occurred to me since the router is already fairly complex and having it be an HTTP filter might be better encapsulated and lower overhead if not used.

[mattklein123]

@alyssawilk @mattklein123 started working on this issue implementing it within the router similar to request_headers_to_add/remove but had a thought - would it be better to implement this as an HTTP filter? This thought occurred to me since the router is already fairly complex and having it be an HTTP filter might be better encapsulated and lower overhead if not used.

I don't have a strong opinion. I think it's fine to build it in as I think that is what most people would expect. There shouldn't be any overhead of not used I don't think. Thanks for implementing!