Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

envoy_reloadable_features_token_passed_entirely deprecation #33627

Closed
adisuissa opened this issue Apr 17, 2024 · 2 comments
Closed

envoy_reloadable_features_token_passed_entirely deprecation #33627

adisuissa opened this issue Apr 17, 2024 · 2 comments
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt

Comments

@adisuissa
Copy link
Contributor

Your change #28678 (Bugfix issue 27877 jwt token with space is valid) introduced a runtime guarded feature. It has been 6 months since the new code has been exercised by default, so it's time to remove the old code path. This issue tracks source code cleanup so we don't forget.
cc @danieldradware
@adisuissa adisuissa added deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt labels Apr 17, 2024
@danieldradware
Copy link
Contributor

Hi @adisuissa,
So should I delete my code from runtime guard?

danieldradware added a commit to Radware/envoy that referenced this issue May 16, 2024
@danieldradware
removed all parts related to runtime guard - envoyproxy#33627
c642081
@danieldradware danieldradware mentioned this issue May 16, 2024
Merged
danieldradware added a commit to Radware/envoy that referenced this issue May 16, 2024
@danieldradware
removed all parts related to runtime guard - envoyproxy#33627
deda219 
Signed-off-by: Daniel Danan <danield@radware.com>
@adisuissa
Copy link
Contributor Author

Hi @adisuissa, So should I delete my code from runtime guard?

Yes, removing the runtime-guard, and the non-used code-paths. Please also add a release note.

danieldradware added a commit to Radware/envoy that referenced this issue May 19, 2024
@danieldradware
removed all parts related to runtime guard - envoyproxy#33627
37d9211 
Signed-off-by: Daniel Danan <danield@radware.com>
danieldradware added a commit to Radware/envoy that referenced this issue May 21, 2024
@danieldradware
removed all parts related to runtime guard - envoyproxy#33627
3222f13 
Signed-off-by: Daniel Danan <danield@radware.com>
danieldradware added a commit to Radware/envoy that referenced this issue May 22, 2024
@danieldradware
removed all parts related to runtime guard - envoyproxy#33627
f3d29fa 
Signed-off-by: Daniel Danan <danield@radware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation Feature deprecation tracking no stalebot Disables stalebot from closing an issue tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@adisuissa @alyssawilk @danieldradware