Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passive TLS inspector #34396

Closed
howardjohn opened this issue May 28, 2024 · 5 comments
Closed

Passive TLS inspector #34396

howardjohn opened this issue May 28, 2024 · 5 comments
Labels
area/tls enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently

Comments

@howardjohn
Copy link
Contributor

Title: Passive TLS inspector

Description:
Envoy currently provides a tls_inspector. This is handy for many use cases.

One use case it is not great for is proxying arbitrary traffic, and logging TLS attributes (generally, the SNI). Use of the inspector causes blocking until enough data is read, which will never happen for server-first protocols like mysql.

Instead, I would like a 'passive' inspector. Data will flow through as-normal, but if it is found to be TLS, some state is stored. Eventually, I would expect to be able to log the SNI on connection termination using the standard access logger

@howardjohn howardjohn added enhancement Feature requests. Not bugs or questions. triage Issue requires triage labels May 28, 2024
@hobbytp
Copy link

hobbytp commented May 31, 2024

@howardjohn can I understand that it will also benefit StartTLS handling?

@howardjohn
Copy link
Contributor Author

I don't know much about StartTLS but I think that is unrelated and already supported by envoy

@jmarantz jmarantz added area/tls and removed triage Issue requires triage labels May 31, 2024
Copy link

github-actions bot commented Jul 1, 2024

This issue has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in the next 7 days unless it is tagged "help wanted" or "no stalebot" or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 1, 2024
Copy link

github-actions bot commented Jul 8, 2024

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as "help wanted" or "no stalebot". Thank you for your contributions.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@howardjohn
Copy link
Contributor Author

Can we reopen this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tls enhancement Feature requests. Not bugs or questions. stale stalebot believes this issue/PR has not been touched recently
Projects
None yet
Development

No branches or pull requests

3 participants