ContextImplTest fails if it has been more than one day since last clean build #704
Comments
|
This tests could use a |
dnoe
added a commit
to dnoe/envoy
that referenced
this issue
Apr 7, 2017
The temporary SSL certificates used for test/common/ssl unit tests were being generated by a Bazel build rule. However, this meant that unless they were missing they were not regenerated. This wasn't really appropriate for the unit test use case since the unit test verifying expiration had expectations about the SSL certificate being generated less than one day before the test ran. Ultimately this resulted in Issue 704 where Bazel builds failed the test if it had been more than 24 hours since the last clean. To fix this the ephemeral certificates used by the unit tests are generated immediately prior to running the test and placed into the Bazel temp directory to be consumed by the test.
mattklein123
pushed a commit
that referenced
this issue
Apr 8, 2017
The temporary SSL certificates used for test/common/ssl unit tests were being generated by a Bazel build rule. However, this meant that unless they were missing they were not regenerated. This wasn't really appropriate for the unit test use case since the unit test verifying expiration had expectations about the SSL certificate being generated less than one day before the test ran. Ultimately this resulted in Issue 704 where Bazel builds failed the test if it had been more than 24 hours since the last clean. To fix this the ephemeral certificates used by the unit tests are generated immediately prior to running the test and placed into the Bazel temp directory to be consumed by the test.
|
fixed by #723 |
rshriram
pushed a commit
to rshriram/envoy
that referenced
this issue
Oct 30, 2018
…roxy#704) * initial CB changes * update debian * init GCS_PATH * del unused files * change != to -n * proxy trigger stuff * only 1 step was run * try to add stuff * try different image * debug * switch back to istiobuilder * try loose * try again * try ubuntu * try ubuntu * try istio * log different file * skip stdout * more power * bazel config * build_proxy_artifacts.yaml * expand * 0.2 is now 0.3 * cleanup * undo customizations * del -release suffix
rshriram
pushed a commit
to rshriram/envoy
that referenced
this issue
Oct 30, 2018
…envoyproxy#704)" (envoyproxy#723) Trying to fix post-submit failure This reverts commit c04ec87.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this issue
Oct 30, 2018
* Revert "Strip out "spiffe://" in the identity (envoyproxy#719)" This reverts commit 99a482f. * Revert "Revert "Remove -release in filename when doing release build of proxy (envoyproxy#704)" (envoyproxy#723)" This reverts commit 13669ce. * Revert "Not to send legacy quota for v2 config. (envoyproxy#722)" This reverts commit aaf25ca.
jpsim
pushed a commit
that referenced
this issue
Nov 28, 2022
Bumping to include #10097, which we'll be utilizing shortly. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this issue
Nov 29, 2022
Bumping to include #10097, which we'll be utilizing shortly. Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The ContextImplTest failed for me this afternoon:
test/common/ssl/context_impl_test.cc:93: Failure
Value of: 15 == context->daysUntilFirstCertExpires() || 14 == context->daysUntilFirstCertExpires()
Actual: false
Expected: true
It has been about a day since I last did a bazel clean, so it appears the problem is that the SSL certs are no longer expiring in the expected timeframe. I will fix this issue properly within the next few days. In the meantime, if you encounter this issue, just run "bazel clean" which will force regeneration of the SSL certs.
The text was updated successfully, but these errors were encountered: