Add verify_subject_alt_name testing to integration tests #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattklein123
reviewed
Apr 8, 2017
| @@ -1,17 +1,17 @@ | |||
| #include "common/ssl/connection_impl.h" | |||
There was a problem hiding this comment.
nit: Can you put newline between "related file" and the other headers. Same below.
| AD/GeVdxA5uNOX1x8DSo1GrdhxEqDEWpmGms0jFoRStgO2PsWNhBoXo/3yPWmsam | ||
| GovtzLF4WapdtSTdn7ku91rx0BplNGOs0uuipnEtRoC7Eo31xaay4LppWTwtVZBA | ||
| LaRR1p0mlCtvqI9dz25Uhl1UlXdvq+lHLxkAFp49CLYf | ||
| MIICmjCCAgOgAwIBAgIJALd7PpOmDaMoMA0GCSqGSIb3DQEBCwUAMIGIMQswCQYD |
There was a problem hiding this comment.
This is kind of embarrassing, but at this point I honestly have no clue what the process is for getting this file updated and checked in. Since you clearly know substantially more about TLS than I do, can you possible add a small README.md to this directory explaining how all of this stuff gets generated and the process for updating.
mattklein123
approved these changes
Apr 10, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Revert "Strip out "spiffe://" in the identity (envoyproxy#719)" This reverts commit 99a482f. * Revert "Revert "Remove -release in filename when doing release build of proxy (envoyproxy#704)" (envoyproxy#723)" This reverts commit 13669ce. * Revert "Not to send legacy quota for v2 config. (envoyproxy#722)" This reverts commit aaf25ca.
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
)" (envoyproxy#733) This reverts commit ef74122.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.