ci: build external deps with BUILD_DISTINCT=1. #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for envoyproxy#716, it's going to temporarily increase the CI image size, but this will go away when we remove the need for cmake.
htuch
added a commit
to htuch/envoy
that referenced
this pull request
Apr 7, 2017
mattklein123
approved these changes
Apr 8, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
* Revert "Strip out "spiffe://" in the identity (envoyproxy#719)" This reverts commit 99a482f. * Revert "Revert "Remove -release in filename when doing release build of proxy (envoyproxy#704)" (envoyproxy#723)" This reverts commit 13669ce. * Revert "Not to send legacy quota for v2 config. (envoyproxy#722)" This reverts commit aaf25ca.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Updates the `ANDROID_LOG_ERROR` calls to instead use `VERBOSE` or `INFO` in order to more appropriately show up in the console. Also updates the tag to use `[Envoy]` for parity with iOS. In the future, we may investigate options for more native logging: envoyproxy/envoy-mobile#719 Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Updates the `ANDROID_LOG_ERROR` calls to instead use `VERBOSE` or `INFO` in order to more appropriately show up in the console. Also updates the tag to use `[Envoy]` for parity with iOS. In the future, we may investigate options for more native logging: envoyproxy/envoy-mobile#719 Signed-off-by: Michael Rebello <me@michaelrebello.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for #716, it's going to temporarily increase the CI image size, but this will go away
when we remove the need for cmake.