Build: Fix unit test cert generation (#704) #723
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The temporary SSL certificates used for test/common/ssl unit tests
were being generated by a Bazel build rule. However, this meant that
unless they were missing they were not regenerated. This wasn't really
appropriate for the unit test use case since the unit test verifying
expiration had expectations about the SSL certificate being generated
less than one day before the test ran. Ultimately this resulted in Issue
704 where Bazel builds failed the test if it had been more than 24 hours
since the last clean.
To fix this the ephemeral certificates used by the unit tests are
generated immediately prior to running the test and placed into the
Bazel temp directory to be consumed by the test.