Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport to 1.13: Prevent SEGFAULT when disabling listener (#13515) #14036

Closed
wants to merge 2 commits into from
Closed

backport to 1.13: Prevent SEGFAULT when disabling listener (#13515) #14036

wants to merge 2 commits into from

Conversation

cpakulski
Copy link
Contributor

Commit Message:
This prevents the stop_listening overload action from causing
segmentation faults that can occur if the action is enabled after the
listener has already shut down.

Risk Level: low
Testing: unit tests
Docs Changes: none
Release Notes: Yes
Fixes #13514

akonradi and others added 2 commits November 16, 2020 16:41
@akonradi @cpakulski
backport: Prevent SEGFAULT when disabling listener (envoyproxy#13515)
96ad79a 
This prevents the stop_listening overload action from causing
segmentation faults that can occur if the action is enabled after the
listener has already shut down.

Signed-off-by: Alex Konradi <akonradi@google.com>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
@cpakulski
code fixes for macos compiler.
e91a80e 
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
@cpakulski
Copy link
Contributor Author

@akonradi I tried to backport #13515 to rel 1.13, but seems that 1.13 branch completely lacks pauseListening, resumeListening and shutdownListener methods. I would have to pull the logic which invokes those methods. Do you think it is worth doing it?

@akonradi
Copy link
Contributor

Nope, the problem is only in calls to those methods. Sounds like there's no bug to be fixed!

@cpakulski
Copy link
Contributor Author

@akonradi Thanks for confirming that! I am closing that PR and mark your original PR as successfully backported.

@cpakulski cpakulski closed this Nov 16, 2020
@cpakulski cpakulski deleted the rel1.13/13515 branch November 16, 2020 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarantz jmarantz Awaiting requested review from jmarantz jmarantz will be requested when the pull request is marked ready for review jmarantz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpakulski @akonradi