Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] tooling: Add jsonschema dump of API (...cont) #15100

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[WIP] tooling: Add jsonschema dump of API (...cont) #15100

wants to merge 1 commit into from

Conversation

phlax
Copy link
Member

@phlax phlax commented Feb 18, 2021 •
edited
Loading

continuation of closed PR #13254

very WIP!

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #15100 was opened by phlax.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Feb 18, 2021
@phlax phlax marked this pull request as draft February 18, 2021 14:38
@phlax phlax force-pushed the api-dump-to-jsonschema branch 2 times, most recently from 81e600a to f631f5e Compare February 19, 2021 14:36
@phlax phlax mentioned this pull request Feb 19, 2021
Merged
@phlax phlax force-pushed the api-dump-to-jsonschema branch 8 times, most recently from dd5be29 to f1044f0 Compare February 21, 2021 20:35
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
API shepherd assignee is @htuch
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #15100 was synchronize by phlax.

see: more, trace.

@phlax phlax force-pushed the api-dump-to-jsonschema branch 7 times, most recently from 593c48a to 80d08dd Compare February 24, 2021 19:05
@phlax phlax mentioned this pull request Feb 25, 2021
Merged
@phlax phlax force-pushed the api-dump-to-jsonschema branch 5 times, most recently from 8ade5ba to c3dd086 Compare February 27, 2021 07:12
@phlax phlax force-pushed the api-dump-to-jsonschema branch 3 times, most recently from 867d4a9 to dcb0152 Compare February 27, 2021 15:49
@phlax phlax force-pushed the api-dump-to-jsonschema branch 3 times, most recently from 5649926 to 3b5ad80 Compare March 22, 2021 15:39
@phlax phlax force-pushed the api-dump-to-jsonschema branch 2 times, most recently from dea371b to dab2a1d Compare April 9, 2021 14:44
@phlax
jsonschema
a08c8ec 
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax mentioned this pull request May 21, 2021
Open
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label May 22, 2021
@phlax phlax added no stalebot Disables stalebot from closing an issue and removed stale stalebot believes this issue/PR has not been touched recently labels May 23, 2021
@mmizutani mmizutani mentioned this pull request Dec 31, 2021
Open
@mmizutani
Copy link

mmizutani commented Dec 31, 2021 •
edited
Loading

After rebasing to the latest main branch HEAD and making a slight modification to this PR branch to catch up with related changes such as #16618, #16496 and #18091, I have successfully generated a JSON schema for the Envoy configuration file based on the latest release version of Envoy (except for CryptoMbPrivateKeyMethodConfig extension).

I am exploring to see if there is any other things that is blocking this improvement PR.

@phlax
Copy link
Member Author

phlax commented Dec 31, 2021

@mmizutani its a while since i worked on this, unfortunately other priorities took precedence

im trying to rem exactly what issues i hit - iirc generating the basic schema was not so problematic, but there were a few additinal hurdles to making it work with vscode

i would be happy to review and/or help with this effort so feel free to ping me if you raise a PR

@htuch htuch removed their assignment Jan 4, 2022
@htuch
Copy link
Member

htuch commented Jan 4, 2022

Clearing myself from assignee until we have a PR ready for review, thanks.

@phlax phlax mentioned this pull request Jan 24, 2022
Open
@phlax phlax mentioned this pull request May 2, 2022
Closed
@norbjd norbjd mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api deps Approval required for changes to Envoy's external dependencies no stalebot Disables stalebot from closing an issue waiting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@phlax @mmizutani @htuch @alyssawilk