Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update RBE toolchain config with 8Mb stack ulimit #16490

Closed
wants to merge 1 commit into from

Conversation

yanavlasov
Copy link
Contributor

Increase ulimti -s to 8Mb to allow large command lines for gcc.

Fixes #16196

Signed-off-by: Yan Avlasov yavlasov@google.com

Signed-off-by: Yan Avlasov <yavlasov@google.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label May 13, 2021
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #16490 was opened by yanavlasov.

see: more, trace.

@yanavlasov
Copy link
Contributor Author

This actually still not working. Figuring out why

@phlax
Copy link
Member

phlax commented May 13, 2021

@yanavlasov not sure if it will fix anything but can you also update the container hashes

see 22351ae for example of what else needs to update

@yanavlasov
Copy link
Contributor Author

Well, we did not change build container images. There are actually no new images in the repo. The last tag is 55d9e4719d2bd0accce8f829b44dab70cd42112a

@moderation
Copy link
Contributor

The deps look OK but if this is not working there isn't a need for deps approval. I'll keep an eye on this PR

@yanavlasov yanavlasov closed this Jun 7, 2021
@yanavlasov yanavlasov deleted the rbe-ulimit branch June 7, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deps Approval required for changes to Envoy's external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gcc build is failing for test targets that depend on //source/exe:envoy_common_lib
4 participants