router: implement upstream log #1986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
mattklein123
reviewed
Nov 2, 2017
There was a problem hiding this comment.
This is really neat. Ultimately I think we will want to add other things in here. For example retry count, etc. But this is a great start. Code looks great also per usual. Thanks a lot for putting the tests in a new file since the other one is already huge. Just one small nit that I see. Also, we will need to fix up the docs for access logging in general when we turn on the v2 docs. I guess initially we can just ref back to v1 docs for format info. cc @htuch
source/common/router/router.h
Outdated
| config.start_child_span()) { | ||
| for (const auto& upstream_log : config.upstream_log()) { | ||
| Http::AccessLog::InstanceSharedPtr current_upstream_log = | ||
| Http::AccessLog::AccessLogFactory::fromProto(upstream_log, context); |
There was a problem hiding this comment.
nit: just fold this into the next line
| const std::string& stat_prefix, | ||
| FactoryContext& context) override; | ||
|
|
||
| ProtobufTypes::MessagePtr createEmptyConfigProto() override { |
Signed-off-by: Stephan Zuercher <stephan@turbinelabs.io>
mattklein123
approved these changes
Nov 3, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
…voyproxy#1986) This reverts commit b33ceb2.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds support for the
upstream_logfield of the v2 API'sRouterHTTP filter. The upstream log reuses the existing access log code for configuring and generating logs. The feature is enabled by adding the appropriate log file configuration to the Router object in the v2 API only.Closes #1927.
API Change: envoyproxy/data-plane-api#211
Risk Level: Medium -- adds code to a heavily used filter.
Testing:
Unit tests to verify that logs are generated when expected and disabled by default.
Additional manual testing with parallel requests.
Release Notes:
Note that api.http.filter.Router upstream_log configuration point is available for use.