router: deprecating total_weight #23170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
|
/retest |
|
Retrying Azure Pipelines: |
|
/lgtm api |
…ation Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
|
Assigning Matt for !Google review. This PR is a follow up to the 0 total-weight for weighted-clusters issue, which we discussed offline. |
This was referenced Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: router: deprecating total_weight
Additional Description:
The
total_weightfield in weighted clusters was used to validate that the sum of weights isn't 0.This PR deprecates the field, and uses the sum of the clusters weights instead. This PR also validates that the sum of weights is above 0 (this constraint was relaxed in #21892).
Risk Level: Low
Testing: Updated current tests.
Docs Changes: Updated
Release Notes: Updated
Platform Specific Features: N/A.
Deprecated:
total_weightfrom weights clusters.Signed-off-by: Adi Suissa-Peleg adip@google.com