golang: L4 network extension #26173
golang: L4 network extension #26173
Conversation
|
Hi @antJack, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
/wait on main merge and CI |
antJack
force-pushed
the
l4-golang-extension
branch
2 times, most recently
from
ff25b3d
to
cd1a5f0
Compare
antJack
force-pushed
the
l4-golang-extension
branch
2 times, most recently
from
d27a841
to
0b4a454
Compare
antJack
force-pushed
the
l4-golang-extension
branch
from
5695b33
to
6f35d41
Compare
There was a problem hiding this comment.
thanks for working on this @antJack - looks very cool
i will do a proper docs review when its ready
/docs
just from skimming through the PR - im wondering is the L4 extension replacing the L7 one ?
if not im wondering about whether we should have a separate sandbox for it
|
Docs for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/26173/docs/index.html The docs are (re-)rendered each time the CI |
|
The L4 extension is not going to replace the L7 one. The different between them is just like the different between envoy's Http::StreamFilter and Network::Filter. And we do need a separate sandbox for L4, I'll work on this. |
antJack
force-pushed
the
l4-golang-extension
branch
5 times, most recently
from
0f89f2e
to
f0995b0
Compare
antJack
force-pushed
the
l4-golang-extension
branch
from
f0995b0
to
0f02a59
Compare
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
|
/retest |
|
Retrying Azure Pipelines: |
api/contrib/envoy/extensions/filters/http/golang/v3alpha/golang.proto
Outdated
Show resolved
Hide resolved
Signed-off-by: yongjie.yyj <yeyeyongjie@gmail.com>
|
great, thanks for updating cc @wbpcode for code review |
|
I've placed the sandbox here: antJack#1 once this pr is ok, I will re-open another one into the envoyproxy:main |
cool, feel free to open it WIP based on this PR - im happy to start reviewing |
done, I open up a wip with sandbox here: #27762 |
Signed-off-by: yongjie.yyj <yeyeyongjie@gmail.com>
|
This is a huge PR orz. So, I think I can only review it on the weekend. orz cc @StarryVae could you help me to take a first pass when you have free time? |
|
yeah, thanks. |
|
Mostly commenting because this is out of review SLO (but I see that's been explained already). But also, might be worth addressing the merge conflicts while you wait for reviewer availability. |
Signed-off-by: yongjie.yyj <yeyeyongjie@gmail.com>
Signed-off-by: yongjie.yyj <yeyeyongjie@gmail.com>
|
@wangfakang @doujiang24 @phlax @wbpcode @StarryVae @ravenblackx Could you please help take a look at this huge PR again? I would be very grateful for your help. |
Signed-off-by: yongjie.yyj <yeyeyongjie@gmail.com>
Signed-off-by: yongjie.yyj <yeyeyongjie@gmail.com>
antJack
force-pushed
the
l4-golang-extension
branch
from
15ebfab
to
59ae99c
Compare
|
/retest |
|
@mattklein123 would you mind taking a pass at this ? |
Signed-off-by: yongjie.yyj <yeyeyongjie@gmail.com> Signed-off-by: asheryer <asheryer@amazon.com>
Signed-off-by: yongjie.yyj <yeyeyongjie@gmail.com> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
Commit Message: l4 golang extension
Additional Description: allow using golang to write envoy network filter
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]