http: route level filter `disabled` support #27210

wbpcode · 2023-05-05T12:11:41Z

Commit Message: http: route level filter config support
Additional Description:

To close #15025, and implement of new API in the #25927. Partly related to #20867.

Specifically, is PR implement two features:
~~1. first, make the route/vh level per filter config could be optional. The old implementation has some problem and may need to be reverted.~~
2. second, a common way to disable a filter by the route/vh level per filter config.

Risk Level: mid.
Testing: wait.
Docs Changes: wait.
Release Notes: wait.
Platform Specific Features: wait.

repokitteh-read-only · 2023-05-05T13:35:00Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @mattklein123
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #27210 was synchronize by wbpcode.

see: more, trace.

wbpcode · 2023-05-05T13:47:46Z

/wait

wbpcode · 2023-05-06T11:22:53Z

/wait

This implementation will add additional hash searching for every filter instance creation. If there are lots filters need to be skipped, then this overhead should acceptable. But for the one who use lots of filters but needn't route level filter disable function, maybe this overhead is a little heavy.

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

api/envoy/config/route/v3/route_components.proto

markdroth

Thanks for fixing this!

source/common/router/config_impl.cc

wbpcode · 2023-05-18T07:36:56Z

/wait #27263

kyessenov · 2023-05-25T16:52:27Z

Looking forward to seeing this land. I think this is super-useful as a generic per-route filter opt-in/opt-out, which is needed by k8s Gateway https://gateway-api.sigs.k8s.io/api-types/httproute/#filters-optional.

wbpcode · 2023-05-26T01:13:17Z

Waiting for #27263 to be land first. But i think we almost get there. 🙂

…oute-filter-config-support

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com>

…oute-filter-config-support

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

wbpcode · 2023-06-08T09:02:05Z

cc @mattklein123
This is a common feature and I choose the header_mutation as an example. A new integration test is added to the header_mutation filter to ensure this new feature could work as expected. 😄

mattklein123

Thanks, needs a main merge though.

…oute-filter-config-support

wbpcode · 2023-06-08T22:08:00Z

cc @mattklein123 done, could you give a new stamp? thanks.

* refactor and fix tests Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * fix test Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * more detailed comments Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * resolve conflict Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * fix test Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * change log and docs Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * Update changelogs/current.yaml Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com> * Update changelogs/current.yaml Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com> * Update changelogs/current.yaml Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com> * Update envoy/http/filter_factory.h Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com> * Update source/common/http/filter_chain_helper.cc Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com> * add new integration test Signed-off-by: wbpcode <wangbaiping@corp.netease.com> --------- Signed-off-by: wbpcode <wangbaiping@corp.netease.com> Signed-off-by: code <wangbaiping@corp.netease.com> Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: asheryer <asheryer@amazon.com>

* refactor and fix tests Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * fix test Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * more detailed comments Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * resolve conflict Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * fix test Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * change log and docs Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * Update changelogs/current.yaml Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com> * Update changelogs/current.yaml Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com> * Update changelogs/current.yaml Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com> * Update envoy/http/filter_factory.h Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com> * Update source/common/http/filter_chain_helper.cc Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com> * add new integration test Signed-off-by: wbpcode <wangbaiping@corp.netease.com> --------- Signed-off-by: wbpcode <wangbaiping@corp.netease.com> Signed-off-by: code <wangbaiping@corp.netease.com> Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>

wbpcode requested review from alyssawilk and mattklein123 as code owners May 5, 2023 12:11

wbpcode marked this pull request as draft May 5, 2023 12:11

wbpcode mentioned this pull request May 5, 2023

http: route level filter chain support #27209

Closed

repokitteh-read-only bot added the api label May 5, 2023

repokitteh-read-only bot assigned mattklein123 May 5, 2023

repokitteh-read-only bot added waiting and removed waiting labels May 5, 2023

repokitteh-read-only bot added waiting and removed waiting labels May 6, 2023

refactor and fix tests

48a6e05

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

wbpcode force-pushed the dev-route-filter-config-support branch from 14f2e02 to 48a6e05 Compare May 7, 2023 07:43

wbpcode changed the title ~~http: route level filter chain support~~ http: route level filter config support May 7, 2023

fix test

d3bd8ec

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

wbpcode marked this pull request as ready for review May 7, 2023 11:13

more detailed comments

92683a8

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

soulxu reviewed May 9, 2023

View reviewed changes

api/envoy/config/route/v3/route_components.proto Outdated Show resolved Hide resolved

soulxu mentioned this pull request May 9, 2023

allow HTTP filters to be marked as optional #15025

Closed

markdroth mentioned this pull request May 9, 2023

router: deprecate optional http filters and add route/vh level is_optional support in the typed_per_filter_config #27263

Merged

markdroth reviewed May 9, 2023

View reviewed changes

source/common/router/config_impl.cc Outdated Show resolved Hide resolved

repokitteh-read-only bot added the waiting label May 18, 2023

wbpcode added 2 commits June 4, 2023 03:20

Merge branch 'main' of https://github.com/envoyproxy/envoy into dev-r…

99dd4b8

…oute-filter-config-support

resolve conflict

dc27506

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

repokitteh-read-only bot removed the waiting label Jun 4, 2023

repokitteh-read-only bot added the waiting label Jun 8, 2023

Update changelogs/current.yaml

1623fbb

Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com>

repokitteh-read-only bot removed the waiting label Jun 8, 2023

code and others added 6 commits June 8, 2023 15:54

Update changelogs/current.yaml

8dde34c

Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com>

Update changelogs/current.yaml

c0b616f

Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com>

Update envoy/http/filter_factory.h

ef3da42

Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com>

Update source/common/http/filter_chain_helper.cc

cb30664

Co-authored-by: Matt Klein <mattklein123@gmail.com> Signed-off-by: code <wangbaiping@corp.netease.com>

Merge branch 'main' of https://github.com/envoyproxy/envoy into dev-r…

c3ea4c4

…oute-filter-config-support

add new integration test

5cce990

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

wbpcode requested a review from htuch as a code owner June 8, 2023 09:00

mattklein123 previously approved these changes Jun 8, 2023

View reviewed changes

Merge branch 'main' of https://github.com/envoyproxy/envoy into dev-r…

7a1c007

…oute-filter-config-support

wbpcode dismissed mattklein123’s stale review via 7a1c007 June 8, 2023 22:07

wbpcode enabled auto-merge (squash) June 8, 2023 22:09

mattklein123 approved these changes Jun 12, 2023

View reviewed changes

wbpcode merged commit eec764f into envoyproxy:main Jun 12, 2023

wbpcode deleted the dev-route-filter-config-support branch June 12, 2023 15:07

wbpcode mentioned this pull request Jun 23, 2023

common inline map registry support #27928

Closed

pchaseh mentioned this pull request Jun 23, 2023

How to disable one of several HTTP filters of the same type #28119

Closed

This was referenced Jul 25, 2023

disable specific http filter by default #28597

Closed

route level http filter chain #20867

Closed

brvn0c mentioned this pull request Sep 6, 2023

Dynamic Forward Proxy with Static Hosts #29452

Closed

zhaohuabing mentioned this pull request Oct 12, 2023

oauth2 filter support per-route configuration #29641

Closed

zhaohuabing mentioned this pull request Oct 24, 2023

feat: api for credential injector http filter #27769

Merged

zhaohuabing mentioned this pull request Feb 20, 2024

route level filter chain - handling requests not matching defined routes #32484

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

http: route level filter `disabled` support #27210

http: route level filter `disabled` support #27210

wbpcode commented May 5, 2023 •

edited

Loading

repokitteh-read-only bot commented May 5, 2023

wbpcode commented May 5, 2023

wbpcode commented May 6, 2023

markdroth left a comment

wbpcode commented May 18, 2023

kyessenov commented May 25, 2023

wbpcode commented May 26, 2023

wbpcode commented Jun 8, 2023 •

edited

Loading

mattklein123 left a comment

wbpcode commented Jun 8, 2023

http: route level filter disabled support #27210

http: route level filter disabled support #27210

Conversation

wbpcode commented May 5, 2023 • edited Loading

repokitteh-read-only bot commented May 5, 2023

wbpcode commented May 5, 2023

wbpcode commented May 6, 2023

markdroth left a comment

Choose a reason for hiding this comment

wbpcode commented May 18, 2023

kyessenov commented May 25, 2023

wbpcode commented May 26, 2023

wbpcode commented Jun 8, 2023 • edited Loading

mattklein123 left a comment

Choose a reason for hiding this comment

wbpcode commented Jun 8, 2023

http: route level filter `disabled` support #27210

http: route level filter `disabled` support #27210

wbpcode commented May 5, 2023 •

edited

Loading

wbpcode commented Jun 8, 2023 •

edited

Loading