deps: update cel-cpp #27414
deps: update cel-cpp #27414
Conversation
Signed-off-by: Kuat Yessenov <kuat@google.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
MSVC does not support weak linkage with ABSL_ATTRIBUTE_WEAK. |
|
It turns out the weak linkage is not necessary for this version of CEL since the new code is not active. |
repokitteh-read-only
bot
removed
the
deps
repokitteh-read-only
bot
added
the
deps
|
@kyessenov it seems this is throwing a lot of warnings in our build - a lot seem to be essentially the same warning Im guessing we can ~safely ignore the warnings - if so im wondering if we can suppress them in the patch or similar |
|
A new update to cel-cpp is in progress google/cel-cpp#167, but it requires very recent protoc/absl - which will not happen quickly. |
|
Will apply the changes in the patch to the cel-cpp SoT repo. However we still need to sort out some issues before we can use cel-cpp HEAD. At this point this will allow CEL matcher work to proceed and patch will go away once we can finally depend on the most recent cel-cpp. |
* deps: update cel-cpp Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
* deps: update cel-cpp Signed-off-by: Kuat Yessenov <kuat@google.com> Signed-off-by: Kuat <kyessenov@users.noreply.github.com>
Commit Message: Updates cel-cpp to latest in OSS. There's another export coming so this PR will be followed up. However, the new export needs the latest protoc, absl, and re2 - which may cause other problems. There is a macro pollution problem with proxy-wasm/proxy-wasm-cpp-sdk#154 addressed by a local patch. I will upstream cel-cpp patch separately.
Risk Level: low
Testing: unit
Docs Changes: none