Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kafka: upgrade dependencies to 3.5.1 #29825

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

adamkotwasinski
Copy link
Contributor

@adamkotwasinski adamkotwasinski commented Sep 27, 2023

Commit Message: kafka: upgrade dependencies to 3.5.1
Additional Description: cherry-pick of #28932 for envoy v1.25 (other commits were related to mesh-filter, but don't want to backport a whole feature)
Risk Level: Low
Testing: integration testing with full stack; manual testing with adamkotwasinski/envoy-kafka-tests#9
Docs Changes: version numbers
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #29825 was opened by adamkotwasinski.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 27, 2023
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #29825 was opened by adamkotwasinski.

see: more, trace.

@adamkotwasinski adamkotwasinski force-pushed the port-kafka-to-125 branch 4 times, most recently from 5cc4077 to 1961150 Compare September 27, 2023 00:25
@adamkotwasinski adamkotwasinski changed the title kafka: upgrade dependencies to 3.5.1 (#28932) kafka: upgrade dependencies to 3.5.1 Sep 27, 2023
@adamkotwasinski
Copy link
Contributor Author

/retest

@adamkotwasinski
Copy link
Contributor Author

all right, so actually it was a very easy one - just a single PR had to be backported

@adamkotwasinski adamkotwasinski marked this pull request as ready for review September 27, 2023 19:02
@adamkotwasinski
Copy link
Contributor Author

/assign @phlax

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks @adamkotwasinski

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Sep 27, 2023
@phlax phlax merged commit 1b95c40 into envoyproxy:release/v1.25 Sep 27, 2023
40 checks passed
@adamkotwasinski adamkotwasinski deleted the port-kafka-to-125 branch October 3, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants