Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to c++ 20 for windows #30472

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

akshaysngupta
Copy link
Contributor

@akshaysngupta akshaysngupta commented Oct 24, 2023

Commit Message: Update c++ to 20 for windows.
Additional Description:
Risk Level:
Testing:
Successful Local build
image

Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Akshay Gupta <akshaysngupta@gmail.com>
@repokitteh-read-only
Copy link

Hi @akshaysngupta, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #30472 was opened by akshaysngupta.

see: more, trace.

@yanavlasov
Copy link
Contributor

Ah, the linker now runs out of memory: https://dev.azure.com/cncf/envoy/_build/results?buildId=153726&view=logs&j=b840a642-5ff3-5357-2e4b-e06e40b0cffd&t=67965174-5100-5631-9dc0-68b9f0aacb53&l=20976

@akshaysngupta do you know if some linker options may help memory usage? I will also check RBE set-up to see what size VMs are used and if larger VM is possible.

/wait-any

@akshaysngupta
Copy link
Contributor Author

akshaysngupta commented Oct 26, 2023

@yanavlasov for oom issue, phlax and I will try a few things like concurrency, isolate if it is bazel client or rbe issue, etc.
for this pr, can you help with a re-attempt on failed jobs?

@yanavlasov
Copy link
Contributor

Restarted failed jobs.

/wait-any

@akshaysngupta
Copy link
Contributor Author

@yanavlasov new github ci for windows is passing for this. I still see the old failed azp win build check as failed.
Any way to remove it from pr checks?

image

@phlax
Copy link
Member

phlax commented Oct 30, 2023

pushing past removed ci

@phlax phlax merged commit 05457bb into envoyproxy:main Oct 30, 2023
236 of 239 checks passed
@akshaysngupta akshaysngupta deleted the aksgupta/c++20 branch October 30, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants