-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to c++ 20 for windows #30472
Update to c++ 20 for windows #30472
Conversation
Signed-off-by: Akshay Gupta <akshaysngupta@gmail.com>
Hi @akshaysngupta, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Ah, the linker now runs out of memory: https://dev.azure.com/cncf/envoy/_build/results?buildId=153726&view=logs&j=b840a642-5ff3-5357-2e4b-e06e40b0cffd&t=67965174-5100-5631-9dc0-68b9f0aacb53&l=20976 @akshaysngupta do you know if some linker options may help memory usage? I will also check RBE set-up to see what size VMs are used and if larger VM is possible. /wait-any |
@yanavlasov for oom issue, phlax and I will try a few things like concurrency, isolate if it is bazel client or rbe issue, etc. |
Restarted failed jobs. /wait-any |
@yanavlasov new github ci for windows is passing for this. I still see the old failed azp win build check as failed. |
pushing past removed ci |
Commit Message: Update c++ to 20 for windows.
Additional Description:
Risk Level:
Testing:
Successful Local build
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]