Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UDP Tunneling: Optionally propagate response headers and trailers to downstream info #30597

Merged

Conversation

IssaAbuKalbein
Copy link
Contributor

@IssaAbuKalbein IssaAbuKalbein commented Oct 29, 2023

Commit Message: Optionally propagate response headers and trailers to downstream info
Additional Description: Add support for saving upstream response headers and trailers to downstream info
Risk Level: low
Testing: integration tests
Docs Changes: API
Release Notes: None
Platform Specific Features: None

Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
@repokitteh-read-only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #30597 was opened by IssaAbuKalbein.

see: more, trace.

Issa Abu Kalbein added 6 commits October 29, 2023 12:10
Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
fix
Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
@lizan
Copy link
Member

lizan commented Oct 31, 2023

/lgtm api

@lizan lizan removed their assignment Oct 31, 2023
@lizan
Copy link
Member

lizan commented Oct 31, 2023

/assign-from @envoyproxy/first-pass-reviewers

@repokitteh-read-only
Copy link

@envoyproxy/first-pass-reviewers assignee is @botengyao

🐱

Caused by: a #30597 (comment) was created by @lizan.

see: more, trace.

@IssaAbuKalbein
Copy link
Contributor Author

ping @botengyao

Copy link
Member

@botengyao botengyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this support! LGTM module one test addition.

Besides, could you also update the changelogs here?

/wait

Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
Issa Abu Kalbein and others added 2 commits November 4, 2023 22:39
Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
Signed-off-by: IssaAbuKalbein <86603440+IssaAbuKalbein@users.noreply.github.com>
@botengyao
Copy link
Member

bazel run //tools/code_format:check_format -- fix is pretty useful and just in case 0/

/wait

Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
fix
Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
fix
Signed-off-by: Issa Abu Kalbein <iabukalbein@microsoft.com>
Copy link
Member

@botengyao botengyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@botengyao
Copy link
Member

/assign-from @envoyproxy/envoy-maintainers

Copy link

@envoyproxy/envoy-maintainers assignee is @htuch

🐱

Caused by: a #30597 (comment) was created by @botengyao.

see: more, trace.

Signed-off-by: IssaAbuKalbein <86603440+IssaAbuKalbein@users.noreply.github.com>
Signed-off-by: IssaAbuKalbein <86603440+IssaAbuKalbein@users.noreply.github.com>
Signed-off-by: IssaAbuKalbein <86603440+IssaAbuKalbein@users.noreply.github.com>
Signed-off-by: IssaAbuKalbein <86603440+IssaAbuKalbein@users.noreply.github.com>
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 876753a into envoyproxy:main Nov 16, 2023
106 checks passed
@IssaAbuKalbein IssaAbuKalbein deleted the propagate_response_headers_and_trailers branch November 16, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants