access log: add support for %UPSTREAM_CONNECTION_ID% #31920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: deveshkandpal1224 <deveshkandpal1224@gmail.com>
Signed-off-by: deveshkandpal1224 <deveshkandpal1224@gmail.com>
deveshkandpal1224
changed the title
Signed-off-by: deveshkandpal1224 <deveshkandpal1224@gmail.com>
|
/retest |
wbpcode
reviewed
Jan 23, 2024
| [](const std::string&, absl::optional<size_t>) { | ||
| return std::make_unique<StreamInfoUInt64FormatterProvider>( | ||
| [](const StreamInfo::StreamInfo& stream_info) { | ||
| return stream_info.upstreamInfo()->upstreamConnectionId().value_or(0); |
There was a problem hiding this comment.
if (stream_info.upstreamInfo().has_value()) {
return stream_info.upstreamInfo()->upstreamConnectionId().value_or(0);
}
return 0;
Signed-off-by: deveshkandpal1224 <deveshkandpal1224@gmail.com>
Signed-off-by: deveshkandpal1224 <deveshkandpal1224@gmail.com>
wbpcode
reviewed
Jan 23, 2024
| @@ -889,7 +889,11 @@ const StreamInfoFormatterProviderLookupTable& getKnownStreamInfoFormatterProvide | |||
| [](const std::string&, absl::optional<size_t>) { | |||
| return std::make_unique<StreamInfoUInt64FormatterProvider>( | |||
| [](const StreamInfo::StreamInfo& stream_info) { | |||
| return stream_info.upstreamInfo()->upstreamConnectionId().value_or(0); | |||
| unsigned long result = 0; | |||
There was a problem hiding this comment.
We rarely use the type name unsigned long, may be uint64_t would be better here.
There was a problem hiding this comment.
@wbpcode - fixed. CI seems to be failing for an unrelated test and I can't seem to restart the test using /retest. Ran the same failing test locally and its succeeding, so i'm guessing its flaky ?
bazel test //test/extensions/filters/http/alternate_protocols_cache:filter_integration_test
Signed-off-by: deveshkandpal1224 <deveshkandpal1224@gmail.com>
|
/retest |
Signed-off-by: deveshkandpal1224 <deveshkandpal1224@gmail.com>
Signed-off-by: deveshkandpal1224 <deveshkandpal1224@gmail.com>
Signed-off-by: deveshkandpal1224 <deveshkandpal1224@gmail.com>
|
/retest |
Signed-off-by: deveshkandpal1224 <deveshkandpal1224@gmail.com>
Signed-off-by: deveshkandpal1224 <deveshkandpal1224@gmail.com>
wbpcode
reviewed
Jan 24, 2024
Comment on lines
682
to
686
| .. _config_access_log_format_upstream_connection_id: | ||
|
|
||
| %UPSTREAM_CONNECTION_ID% | ||
| An identifier for the upstream connection. | ||
|
|
There was a problem hiding this comment.
Thanks for you in timely update 😄 . This LGTM overall. Please supplement more context about the new command in the docs. I think this description should almost same with the CONNECTION_ID except it's used to tell the upstream connection id.
|
/wait |
Signed-off-by: deveshkandpal1224 <deveshkandpal1224@gmail.com>
mattklein123
pushed a commit
that referenced
this pull request
Sep 8, 2024
…lows (#35950) Additional Description: The following PR: #31920, added support for ``%UPSTREAM_CONNECTION_ID`` substitution string for access logs. However, it's only supported for HTTP flows. Adding support for UDP and TCP tunneling Risk Level: low Testing: unit tests, integration tests Docs Changes: none Release Notes: none Platform Specific Features: none --------- Signed-off-by: Ohad Vano <ohadvano@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to print
%UPSTREAM_CONNECTION_ID%in access log. Currently,%CONNECTION_ID%is supported which prints downstream connection id in access log. Primary motivation for add this is to easily debug reuse of an existing connection while debugging communication between client -> server especially during draining of upstream envoy.Commit Message: Add support for %UPSTREAM_CONNECTION_ID% in access log
Additional Description: Primary motivation for add this is to easily reason reuse of an existing connection while debugging communication between client -> server.
Risk Level: low
Testing: unit testing
Docs Changes: updated
Release Notes: updated