Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext_proc: Update the proto comment #32031

Merged
merged 5 commits into from
Jan 29, 2024
Merged

ext_proc: Update the proto comment #32031

merged 5 commits into from
Jan 29, 2024

Conversation

tyxia
Copy link
Member

@tyxia tyxia commented Jan 25, 2024 •
edited
Loading

Update the stale info in the proto.

The design has already been updated to: Only sent body and trailer if the processing mode is set to SEND and
they are present in original request/response.

Reference :
#28620
doc

Fixes: #32029
Thanks @sanjaypujare for finding and reporting this.

@tyxia
ext_proc: Update the proto
3f981b7 
Signed-off-by: tyxia <tyxia@google.com>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #32031 was opened by tyxia.

see: more, trace.

@repokitteh-read-only RepoKitteh - Read Only
Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @abeyad
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #32031 was opened by tyxia.

see: more, trace.

@tyxia tyxia changed the title ext_proc: Update the proto ext_proc: Update the proto comment to reflect the latest info Jan 25, 2024
@tyxia tyxia marked this pull request as ready for review January 25, 2024 14:06
@tyxia
Copy link
Member Author

tyxia commented Jan 25, 2024 •
edited
Loading

cc @yanavlasov @yanjunxiang-google

since they were involved in this design update.

@tyxia
Copy link
Member Author

tyxia commented Jan 25, 2024

/assign @yanavlasov @yanjunxiang-google

Also, add them as reviewers

@tyxia tyxia changed the title ext_proc: Update the proto comment to reflect the latest info ext_proc: Update the proto comment Jan 25, 2024
@tyxia tyxia mentioned this pull request Jan 25, 2024
Closed
adisuissa
adisuissa reviewed Jan 25, 2024
View reviewed changes
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!
Are there tests for this behavior?
Was the behavior always like that and the API comment was wrong or was it due to a code change?

/wait

api/envoy/service/ext_proc/v3/external_processor.proto Outdated Show resolved Hide resolved
api/envoy/service/ext_proc/v3/external_processor.proto Outdated Show resolved Hide resolved
@tyxia
update
81671bf 
Signed-off-by: tyxia <tyxia@google.com>
@tyxia
update
517168d 
Signed-off-by: tyxia <tyxia@google.com>
@tyxia
Copy link
Member Author

tyxia commented Jan 25, 2024

Thanks for updating this! Are there tests for this behavior? Was the behavior always like that and the API comment was wrong or was it due to a code change?

/wait

Yea, the code and test have been updated, for example, in #28592
So there are already tests in place.

abeyad
abeyad previously approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@abeyad abeyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm api

@tyxia
update
20ac9ef 
Signed-off-by: tyxia <tyxia@google.com>
@tyxia
Copy link
Member Author

tyxia commented Jan 25, 2024

Sorry @abeyad , I need the stamp again. (Just updated another typo).

adisuissa
adisuissa approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
/lgtm api

@abeyad
Copy link
Contributor

abeyad commented Jan 25, 2024

/lgtm api

@yanjunxiang-google
Copy link
Contributor

LGTM

@tyxia
Merge branch 'main' of https://github.com/envoyproxy/envoy into ext_p…
bd1c6cf 
…roc_proto

Signed-off-by: tyxia <tyxia@google.com>
@yanavlasov yanavlasov enabled auto-merge (squash) January 29, 2024 15:04
@yanavlasov yanavlasov merged commit 07f6286 into envoyproxy:main Jan 29, 2024
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanjunxiang-google yanjunxiang-google yanjunxiang-google approved these changes

@yanavlasov yanavlasov yanavlasov approved these changes

@adisuissa adisuissa adisuissa approved these changes

@abeyad abeyad abeyad approved these changes

Assignees

@abeyad abeyad

@yanavlasov yanavlasov

@yanjunxiang-google yanjunxiang-google

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typos in ext_proc documentation
5 participants
@tyxia @abeyad @yanjunxiang-google @adisuissa @yanavlasov