Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opentelemetry: set status code #33674

Merged
merged 6 commits into from
Apr 23, 2024

Conversation

zirain
Copy link
Contributor

@zirain zirain commented Apr 19, 2024

Commit Message: set span status code base on http status code for OpenTelemetry tracer, xref: istio/istio#50195
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] #32114
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from htuch as a code owner April 19, 2024 03:01
@adisuissa
Copy link
Contributor

/assign-from @envoyproxy/first-pass-reviewers

Copy link

@envoyproxy/first-pass-reviewers assignee is @silverstar194

🐱

Caused by: a #33674 (comment) was created by @adisuissa.

see: more, trace.

Signed-off-by: zirain <zirain2009@gmail.com>
Copy link
Contributor

@adisuissa adisuissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.
Please add a release note.
Assigning @htuch as codeowner.
/assign @htuch

Signed-off-by: zirain <zirain2009@gmail.com>
Signed-off-by: zirain <zirain2009@gmail.com>
@zirain zirain requested a review from adisuissa April 21, 2024 03:20
changelogs/current.yaml Outdated Show resolved Hide resolved
htuch
htuch previously approved these changes Apr 22, 2024
Copy link
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo nit comment.

Signed-off-by: zirain <zirain2009@gmail.com>
@wbpcode wbpcode merged commit afeb301 into envoyproxy:main Apr 23, 2024
52 checks passed
@zirain zirain deleted the otel-accesslog-responsecode branch April 23, 2024 02:09
cainelli pushed a commit to cainelli/envoy that referenced this pull request Apr 25, 2024
* opentelemetry: set status code for tracer

Signed-off-by: zirain <zirain2009@gmail.com>

* improve comment

Signed-off-by: zirain <zirain2009@gmail.com>

* split test

Signed-off-by: zirain <zirain2009@gmail.com>

* changelogs

Signed-off-by: zirain <zirain2009@gmail.com>

* update changelog

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
alyssawilk pushed a commit to alyssawilk/envoy that referenced this pull request Apr 29, 2024
* opentelemetry: set status code for tracer

Signed-off-by: zirain <zirain2009@gmail.com>

* improve comment

Signed-off-by: zirain <zirain2009@gmail.com>

* split test

Signed-off-by: zirain <zirain2009@gmail.com>

* changelogs

Signed-off-by: zirain <zirain2009@gmail.com>

* update changelog

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
ashishb-solo pushed a commit to solo-io/envoy-fork that referenced this pull request Jul 5, 2024
* opentelemetry: set status code for tracer

Signed-off-by: zirain <zirain2009@gmail.com>

* improve comment

Signed-off-by: zirain <zirain2009@gmail.com>

* split test

Signed-off-by: zirain <zirain2009@gmail.com>

* changelogs

Signed-off-by: zirain <zirain2009@gmail.com>

* update changelog

Signed-off-by: zirain <zirain2009@gmail.com>

---------

Signed-off-by: zirain <zirain2009@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants