Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mobile: Add scripts to run the Android apps locally #34329

Merged
merged 1 commit into from
May 23, 2024
Merged

mobile: Add scripts to run the Android apps locally #34329

merged 1 commit into from
May 23, 2024

Conversation

fredyw
Copy link
Member

@fredyw fredyw commented May 23, 2024 •
edited
Loading

This should make it easier to do local development or debugging issues related to the test apps.

Risk Level: n/a
Testing: manual
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

@fredyw
Add scripts to run the Android apps locally
2ce6277 
Signed-off-by: Fredy Wijaya <fredyw@google.com>
@repokitteh-read-only RepoKitteh - Read Only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #34329 was opened by fredyw.

see: more, trace.

@fredyw fredyw marked this pull request as ready for review May 23, 2024 20:31
@fredyw
Copy link
Member Author

fredyw commented May 23, 2024

/assign @abeyad

@fredyw fredyw enabled auto-merge (squash) May 23, 2024 20:31
abeyad
abeyad approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@abeyad abeyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks!

@fredyw
Copy link
Member Author

fredyw commented May 23, 2024

/retest

@fredyw fredyw merged commit 37cbd76 into envoyproxy:main May 23, 2024
34 of 35 checks passed
@fredyw fredyw deleted the android_app_local_dev branch May 23, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeyad abeyad abeyad approved these changes

@RyanTheOptimist RyanTheOptimist Awaiting requested review from RyanTheOptimist RyanTheOptimist is a code owner

@alyssawilk alyssawilk Awaiting requested review from alyssawilk alyssawilk is a code owner

Assignees

@abeyad abeyad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fredyw @abeyad