upstream: set host on stream info for upstream filters #34332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ia868bb4d9cbf78de23bc43b6a162edcc065aa762 Signed-off-by: Kuat Yessenov <kuat@google.com>
ggreenway
reviewed
May 29, 2024
| @@ -572,6 +572,9 @@ Host::CreateConnectionData HostImplBase::createConnection( | |||
| connection->connectionInfoSetter().enableSettingInterfaceName( | |||
| cluster.setLocalInterfaceNameOnUpstreamConnections()); | |||
| connection->setBufferLimits(cluster.perConnectionBufferLimitBytes()); | |||
| if (auto upstream_info = connection->streamInfo().upstreamInfo(); upstream_info) { | |||
There was a problem hiding this comment.
In what cases does the streaminfo not have an upstreaminfo?
There was a problem hiding this comment.
When the socket errors out early in the code path. I'm not sure it was placed that way, but better be safe.
ggreenway
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ia868bb4d9cbf78de23bc43b6a162edcc065aa762
Commit Message: set host info on stream info for upstream filters. This is useful in upstream filters since the host is known.
Risk Level: low
Testing: regression