tls: fix duplicated ':TLS_error_end' suffix in socket failure reason #34799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix also prevents duplicated debug logs, since they are always generated after the end suffix is appended to the failure reason. Signed-off-by: Joe Kralicky <joekralicky@gmail.com>
|
/assign @botengyao Could you take a first pass on this? as you worked on this before. |
botengyao
reviewed
Jun 24, 2024
| } else { | ||
| EXPECT_THAT(log_result, | ||
| StartsWith("DOWNSTREAM_TRANSPORT_FAILURE_REASON=TLS_error:|268435640:" | ||
| "SSL_routines:OPENSSL_internal:NO_SHARED_CIPHER:TLS_error_end")); |
There was a problem hiding this comment.
Is previous test ending with 2 TLS_error_ends here?
There was a problem hiding this comment.
Yes, the full log_result text here (in main) is
"DOWNSTREAM_TRANSPORT_FAILURE_REASON=TLS_error:|268435640:SSL_routines:OPENSSL_internal:NO_SHARED_CIPHER:TLS_error_end:TLS_error_end FILTER_CHAIN_NAME=-"
but it passed since it was only checking the prefix.
|
/retest |
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…nvoyproxy#34799) This fix also prevents duplicated debug logs, since they are always generated after the end suffix is appended to the failure reason. Signed-off-by: Joe Kralicky <joekralicky@gmail.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…nvoyproxy#34799) This fix also prevents duplicated debug logs, since they are always generated after the end suffix is appended to the failure reason. Signed-off-by: Joe Kralicky <joekralicky@gmail.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…nvoyproxy#34799) This fix also prevents duplicated debug logs, since they are always generated after the end suffix is appended to the failure reason. Signed-off-by: Joe Kralicky <joekralicky@gmail.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
cainelli
pushed a commit
to cainelli/envoy
that referenced
this pull request
Jul 5, 2024
…nvoyproxy#34799) This fix also prevents duplicated debug logs, since they are always generated after the end suffix is appended to the failure reason. Signed-off-by: Joe Kralicky <joekralicky@gmail.com> Signed-off-by: Fernando Cainelli <fernando.cainelli-external@getyourguide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: tls: fix duplicated ':TLS_error_end' suffix in socket failure reason
This fix also prevents duplicated debug logs, since they are always generated after the end suffix is appended to the failure reason.
Additional Description:
Follow-up to #34741
Risk Level: low (no guarantees are made about the format of this message); searching the string
:TLS_error_end:TLS_error_endin github returns no results other than the test code in the PR linked aboveTesting: updated existing tests that checked this string
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]