alpn: move requested alpn to connection info #34803
Conversation
Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
Signed-off-by: Boteng Yao <boteng@google.com>
|
/assign @yanavlasov |
...mmon/router/test_corpus/clusterfuzz-testcase-minimized-route_fuzz_test-5085115349270528.fuzz
Outdated
Show resolved
Hide resolved
| /** | ||
| * @return requested application protocol(s) (e.g. ALPN in TLS), if any. | ||
| */ | ||
| virtual const std::vector<std::string>& requestedApplicationProtocols() const PURE; |
There was a problem hiding this comment.
Can you clarify why you need to add this? Is this to support filter chain matcher?
There was a problem hiding this comment.
not really, I think there is no way to let network filter to get this info due to interface limit to let upstream also consume this info.
Signed-off-by: Boteng Yao <boteng@google.com>
|
/wait for a further discussion |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Move requested alpn to downstream connection_info for better access from filters.
This is similar as
requestedServerNameCommit Message:
Additional Description:
Risk Level: low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]