-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ext_proc: Switch to use address of stream as the key #34959
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
stale
stalebot believes this issue/PR has not been touched recently
label
Jul 28, 2024
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
…ream_id Signed-off-by: tyxia <tyxia@google.com>
github-actions
bot
removed
the
stale
stalebot believes this issue/PR has not been touched recently
label
Aug 7, 2024
/assign @yanavlasov |
yanavlasov
approved these changes
Aug 8, 2024
martinduke
pushed a commit
to martinduke/envoy
that referenced
this pull request
Aug 8, 2024
Switch to use address of stream as the key to avoid any potential key duplication --------- Signed-off-by: tyxia <tyxia@google.com> Signed-off-by: Martin Duke <martin.h.duke@gmail.com>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
Switch to use address of stream as the key to avoid any potential key duplication --------- Signed-off-by: tyxia <tyxia@google.com> Signed-off-by: asingh-g <abhisinghx@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: Switch to use address of stream as the key to avoid any potential key duplication
Additional Description:
Risk Level: Low
Testing: Existing test coverage
Docs Changes: N/A
Release Notes: N/A