Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext_proc: Switch to use address of stream as the key #34959

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

tyxia
Copy link
Member

@tyxia tyxia commented Jun 27, 2024

Commit Message: Switch to use address of stream as the key to avoid any potential key duplication
Additional Description:
Risk Level: Low
Testing: Existing test coverage
Docs Changes: N/A
Release Notes: N/A

Signed-off-by: tyxia <tyxia@google.com>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #34959 was opened by tyxia.

see: more, trace.

Signed-off-by: tyxia <tyxia@google.com>
@github-actions github-actions bot added the stale stalebot believes this issue/PR has not been touched recently label Jul 28, 2024
Copy link

github-actions bot commented Aug 4, 2024

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot closed this Aug 4, 2024
…ream_id

Signed-off-by: tyxia <tyxia@google.com>
@tyxia tyxia reopened this Aug 7, 2024
@github-actions github-actions bot removed the stale stalebot believes this issue/PR has not been touched recently label Aug 7, 2024
Signed-off-by: tyxia <tyxia@google.com>
@tyxia tyxia marked this pull request as ready for review August 8, 2024 00:24
@tyxia tyxia changed the title WIP ext_proc: Switch to use address of stream as the key Aug 8, 2024
@tyxia
Copy link
Member Author

tyxia commented Aug 8, 2024

/assign @yanavlasov

@yanavlasov yanavlasov merged commit ccae683 into envoyproxy:main Aug 8, 2024
50 checks passed
martinduke pushed a commit to martinduke/envoy that referenced this pull request Aug 8, 2024
Switch to use address of stream as the key to avoid any potential key duplication

---------

Signed-off-by: tyxia <tyxia@google.com>
Signed-off-by: Martin Duke <martin.h.duke@gmail.com>
@envoyproxy envoyproxy deleted a comment from github-actions bot Aug 9, 2024
@tyxia tyxia deleted the ob_stream_id branch August 9, 2024 14:11
asingh-g pushed a commit to asingh-g/envoy that referenced this pull request Aug 20, 2024
Switch to use address of stream as the key to avoid any potential key duplication

---------

Signed-off-by: tyxia <tyxia@google.com>
Signed-off-by: asingh-g <abhisinghx@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants