c-ares gRPC library: fix a bug impacting gRPC's use of c-ares #35487
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
|
/retest |
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
There was a problem hiding this comment.
Thanks @adisuissa! This LGTM.
I am wondering if we can upgrade c-ares to 1.21.0 that includes this fix.
It may be, but seeing that later versions were broken, I think it might be better to solve the current issue, and later upgrade to a new version of c-ares. |
|
/assign @phlax Context: users of Envoy v1.31 experienced an issue using a GoogleGrpc service, when the gRPC service needed to resolve a domain name. We tracked it down to a bug in C-Ares that was fixed in this PR. |
repokitteh-read-only
bot
removed
the
deps
…es (envoyproxy#35487) Signed-off-by: Adi Suissa-Peleg <adip@google.com>
#35511) Signed-off-by: Adi Suissa-Peleg <adip@google.com>
…roxy#35487) Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Martin Duke <martin.h.duke@gmail.com>
…roxy#35487) Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: asingh-g <abhisinghx@google.com>
Commit Message: c-ares gRPC library: fix a bug impacting gRPC's use of c-ares
Additional Description:
When a GoogleGrpc service is configured with a domain name and using C-Ares as a resolver results in an immediate disconnect.
The fix (c-ares/c-ares@a070d78) is being imported as a patch until c-ares can be upgraded.
Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A