test interaction between drain upon completion & onDrainTimeout #35568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniovleonti
force-pushed
the
cx-close-test
branch
3 times, most recently
from
5108d1b
to
28d4ab1
Compare
Signed-off-by: antoniovleonti <leonti@google.com>
antoniovleonti
force-pushed
the
cx-close-test
branch
from
28d4ab1
to
c6dd003
Compare
|
/retest |
Signed-off-by: antoniovleonti <leonti@google.com>
Signed-off-by: antoniovleonti <leonti@google.com>
|
Much better, thanks. |
Signed-off-by: antoniovleonti <leonti@google.com>
alyssawilk
reviewed
Aug 8, 2024
Signed-off-by: antoniovleonti <leonti@google.com>
alyssawilk
approved these changes
Aug 8, 2024
|
/retest |
RyanTheOptimist
pushed a commit
that referenced
this pull request
Aug 12, 2024
Commit Message: test: update a broken test due to PRs race Additional Description: PR #35568 used an old `setup()` method call which was modified by PR #35209 that was merged just before it, causing a build failure. This PR update the test and fixes the build failure. Risk Level: low Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Adi Suissa-Peleg <adip@google.com>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
…yproxy#35568) Commit Message: test interaction between drain upon completion & onDrainTimeout Additional Description: adds unit & integration tests that demonstrate it is safe to use max_requests_per_connection with max_connection_duration, idle_timeout, and max_stream_duration. (idle_timeout is not explicitly tested but triggers the same exact drain behavior as max_connection_duration.) Risk Level: none Testing: test-only PR --------- Signed-off-by: antoniovleonti <leonti@google.com> Signed-off-by: asingh-g <abhisinghx@google.com>
asingh-g
pushed a commit
to asingh-g/envoy
that referenced
this pull request
Aug 20, 2024
Commit Message: test: update a broken test due to PRs race Additional Description: PR envoyproxy#35568 used an old `setup()` method call which was modified by PR envoyproxy#35209 that was merged just before it, causing a build failure. This PR update the test and fixes the build failure. Risk Level: low Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: asingh-g <abhisinghx@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: test interaction between drain upon completion & onDrainTimeout
Additional Description:
adds unit & integration tests that demonstrate it is safe to use max_requests_per_connection with max_connection_duration, idle_timeout, and max_stream_duration.
(idle_timeout is not explicitly tested but triggers the same exact drain behavior as max_connection_duration.)
Risk Level: none
Testing: test-only PR