Revert "rbac: add delay_deny implementation in RBAC network filter (#… #35899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nvoyproxy#33875)" This reverts commit bf65ad3. Signed-off-by: Ryan Northey <ryan@synca.io>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
cc @yangminzhu |
|
Three weeks past. This revert will also introduce a unexpected/break API change. cc @envoyproxy/api-shepherds Or could we disable the test temporarily if that is not an actual bug? cc @yangminzhu |
|
Seems the @yangminzhu has no activity on GitHub recently. Then, let's revert it directly if no explicit objection from @envoyproxy/api-shepherds |
ggreenway
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…33875)"
This reverts commit bf65ad3.
Fix #35653