Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: Remove unnecessary auto-boxing #36012

Merged
merged 1 commit into from
Sep 7, 2024

Conversation

fredyw
Copy link
Member

@fredyw fredyw commented Sep 6, 2024

Unnecessary auto-boxing from primitive to non-primitive types is wasteful.

Risk Level: low
Testing: CI
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: mobile

Signed-off-by: Fredy Wijaya <fredyw@google.com>
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #36012 was opened by fredyw.

see: more, trace.

@fredyw fredyw marked this pull request as ready for review September 6, 2024 19:11
@fredyw
Copy link
Member Author

fredyw commented Sep 6, 2024

/assign @abeyad

@fredyw
Copy link
Member Author

fredyw commented Sep 6, 2024

/retest

1 similar comment
@fredyw
Copy link
Member Author

fredyw commented Sep 6, 2024

/retest

@fredyw fredyw changed the title mobile: Remove unnecessary boxing mobile: Remove unnecessary auto-boxing Sep 6, 2024
@abeyad abeyad merged commit 18cbe86 into envoyproxy:main Sep 7, 2024
31 checks passed
@fredyw fredyw deleted the remove_unncessary_boxing branch September 7, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants