bazel: Update to 0.28.0 #7533
Merged
bazel: Update to 0.28.0 #7533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
|
I might have some follow ups here, we'll see what CI says |
Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
lizan
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
Thanks @keith. I'm in favor of merging this before 1.11.0 release as 0.27.0 has some drawbacks, i.e. official release doesn't run on Trusty, CentOS. Defer merging to @alyssawilk
|
I defer right on back to you and @htuch as I think you two can assess risk better |
|
got a verbal thumbs up from Harvey. Let's do it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Keith Smiley keithbsmiley@gmail.com